Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react and react-dom from the package.json dependencies #5

Closed
wants to merge 1 commit into from
Closed

Remove react and react-dom from the package.json dependencies #5

wants to merge 1 commit into from

Conversation

mmacai
Copy link

@mmacai mmacai commented Sep 5, 2022

Removed react and react-dom from the package.json dependencies. Should help with newer version of React.

Closes #4

@mmacai
Copy link
Author

mmacai commented Sep 5, 2022

@omerg Did what you proposed in the #4, but it seems it broke the pipelines.

Error: Cannot find module 'react/package.json'

Any idea what else to update?

@omerg
Copy link
Owner

omerg commented Dec 16, 2022

Thanks for the pull request @mmacai ! 👍 The error should be fixed with another PR released earlier, that transfers the dependencies to dev deps array, instead of removing them:

#6

Therefore closing this one. Your contribution is greatly appreciated 🙏 😊

@omerg omerg closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid hook call on react 17
2 participants
@mmacai @omerg